-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[dashboard] remove dashboard_error_handling functional test #224110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ci |
💚 Build Succeeded
Metrics [docs]
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Jun 16, 2025
TattdCodeMonkey
approved these changes
Jun 17, 2025
Starting backport for target branches: 8.19 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 17, 2025
…224110) PR removes `dashboard_error_handling.ts` functional test. Test case are covered with unit tests in [EmbeddableRenderer](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/embeddable/public/react_embeddable_system/react_embeddable_renderer.test.tsx#L188) and [PresentationPanelInternal](https://github.com/elastic/kibana/blob/main/src/platform/plugins/private/presentation_panel/public/panel_component/presentation_panel_internal.test.tsx#L53) (cherry picked from commit 8222467)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 17, 2025
…224110) (#224278) # Backport This will backport the following commits from `main` to `8.19`: - [[dashboard] remove dashboard_error_handling functional test (#224110)](#224110) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-06-17T14:56:17Z","message":"[dashboard] remove dashboard_error_handling functional test (#224110)\n\nPR removes `dashboard_error_handling.ts` functional test. Test case are\ncovered with unit tests in\n[EmbeddableRenderer](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/embeddable/public/react_embeddable_system/react_embeddable_renderer.test.tsx#L188)\nand\n[PresentationPanelInternal](https://github.com/elastic/kibana/blob/main/src/platform/plugins/private/presentation_panel/public/panel_component/presentation_panel_internal.test.tsx#L53)","sha":"8222467557d8099e117a5679c0c13a1b172e679d","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","backport:version","v9.1.0","v8.19.0"],"title":"[dashboard] remove dashboard_error_handling functional test","number":224110,"url":"https://github.com/elastic/kibana/pull/224110","mergeCommit":{"message":"[dashboard] remove dashboard_error_handling functional test (#224110)\n\nPR removes `dashboard_error_handling.ts` functional test. Test case are\ncovered with unit tests in\n[EmbeddableRenderer](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/embeddable/public/react_embeddable_system/react_embeddable_renderer.test.tsx#L188)\nand\n[PresentationPanelInternal](https://github.com/elastic/kibana/blob/main/src/platform/plugins/private/presentation_panel/public/panel_component/presentation_panel_internal.test.tsx#L53)","sha":"8222467557d8099e117a5679c0c13a1b172e679d"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224110","number":224110,"mergeCommit":{"message":"[dashboard] remove dashboard_error_handling functional test (#224110)\n\nPR removes `dashboard_error_handling.ts` functional test. Test case are\ncovered with unit tests in\n[EmbeddableRenderer](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/embeddable/public/react_embeddable_system/react_embeddable_renderer.test.tsx#L188)\nand\n[PresentationPanelInternal](https://github.com/elastic/kibana/blob/main/src/platform/plugins/private/presentation_panel/public/panel_component/presentation_panel_internal.test.tsx#L53)","sha":"8222467557d8099e117a5679c0c13a1b172e679d"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR removes
dashboard_error_handling.ts
functional test. Test case are covered with unit tests in EmbeddableRenderer and PresentationPanelInternal