Skip to content

[dashboard] remove dashboard_error_handling functional test #224110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jun 16, 2025

PR removes dashboard_error_handling.ts functional test. Test case are covered with unit tests in EmbeddableRenderer and PresentationPanelInternal

@nreese
Copy link
Contributor Author

nreese commented Jun 16, 2025

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@nreese nreese marked this pull request as ready for review June 16, 2025 19:26
@nreese nreese requested review from a team as code owners June 16, 2025 19:26
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 16, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese merged commit 8222467 into elastic:main Jun 17, 2025
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15710772128

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 17, 2025
…224110) (#224278)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[dashboard] remove dashboard_error_handling functional test
(#224110)](#224110)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-06-17T14:56:17Z","message":"[dashboard]
remove dashboard_error_handling functional test (#224110)\n\nPR removes
`dashboard_error_handling.ts` functional test. Test case are\ncovered
with unit tests
in\n[EmbeddableRenderer](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/embeddable/public/react_embeddable_system/react_embeddable_renderer.test.tsx#L188)\nand\n[PresentationPanelInternal](https://github.com/elastic/kibana/blob/main/src/platform/plugins/private/presentation_panel/public/panel_component/presentation_panel_internal.test.tsx#L53)","sha":"8222467557d8099e117a5679c0c13a1b172e679d","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","backport:version","v9.1.0","v8.19.0"],"title":"[dashboard]
remove dashboard_error_handling functional
test","number":224110,"url":"https://github.com/elastic/kibana/pull/224110","mergeCommit":{"message":"[dashboard]
remove dashboard_error_handling functional test (#224110)\n\nPR removes
`dashboard_error_handling.ts` functional test. Test case are\ncovered
with unit tests
in\n[EmbeddableRenderer](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/embeddable/public/react_embeddable_system/react_embeddable_renderer.test.tsx#L188)\nand\n[PresentationPanelInternal](https://github.com/elastic/kibana/blob/main/src/platform/plugins/private/presentation_panel/public/panel_component/presentation_panel_internal.test.tsx#L53)","sha":"8222467557d8099e117a5679c0c13a1b172e679d"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224110","number":224110,"mergeCommit":{"message":"[dashboard]
remove dashboard_error_handling functional test (#224110)\n\nPR removes
`dashboard_error_handling.ts` functional test. Test case are\ncovered
with unit tests
in\n[EmbeddableRenderer](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/embeddable/public/react_embeddable_system/react_embeddable_renderer.test.tsx#L188)\nand\n[PresentationPanelInternal](https://github.com/elastic/kibana/blob/main/src/platform/plugins/private/presentation_panel/public/panel_component/presentation_panel_internal.test.tsx#L53)","sha":"8222467557d8099e117a5679c0c13a1b172e679d"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants