@nocommit Make ReactTextChangedEvent syncronous #52534
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Those constructors are no longer necessary. They're deprecated + the class is internal so they're not breaking changes. I'm just cleaning them up as they're not needed anymore. Changelog: [Internal] [Changed] - Remove deprecated constructors for TextInput *Event classes Differential Revision: D78095748
Summary: Fixes facebook#46813 Users are reporting that TextInput is flickering in multiline when adding/removing lines of text (see videos in facebook#46813). One possible solution for this is to make `ReactTextChangedEvent` syncronous so the rendering of the intermediate frame will be blocked. Changelog: [Android] [Fixed] - **TextInput:** Fixing TextInput jumping when adding/removing line of text due to delayed layout update happening after content update Differential Revision: D78096197
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78096197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #46813
Users are reporting that TextInput is flickering in multiline when adding/removing lines of text (see videos in #46813).
One possible solution for this is to make
ReactTextChangedEventsyncronous so the rendering of the intermediate frame will be blocked.Changelog:
[Android] [Fixed] - TextInput: Fixing TextInput jumping when adding/removing line of text due to delayed layout update happening after content update
Differential Revision: D78096197