Pipeline tests part 2 #14951
Pipeline tests part 2 #14951
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Generated by 🚫 Danger |
cherylEnkidu
force-pushed
the
cheryllin/ppltests2
branch
from
47785df to
51086da
Compare
| result.map_value.fields[0].key = nanopb::MakeBytesArray("expression"); | ||
| result.map_value.fields[0].value = expr_->to_proto(); | ||
| result.map_value.fields[1].key = nanopb::MakeBytesArray("direction"); | ||
|
|
There was a problem hiding this comment.
Curious why the "order" is flipped here. It is a map, so the order should not matter?
There was a problem hiding this comment.
It should not matter. I changed this when I debugging other things and doing a cross comparison with the web sdk.
No description provided.