-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Infra] Use strict patch versions for internal podspec dependencies #15049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This change updates all internal podspec dependencies to use strict versioning, pinned to the patch version. - Dependencies using optimistic versioning (`~>`) are changed to strict versions (e.g., `~> 12.0.0` to `12.0.0`). - Dependencies already using exact versions pinned to the minor (e.g., `12.0`) are changed to pin to the patch version (e.g., `12.0` to `12.0.0`). This ensures that the build process uses exact versions of internal dependencies, preventing potential compatibility issues and providing more precise version control.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
This change updates all internal podspec dependencies to float to the patch version (e.g., `~> X.Y.Z`). This allows for more flexibility in patch releases while maintaining stability for minor and major versions, as discussed in the PR feedback. - Strict versions (e.g., `X.Y.Z`) are changed to `~> X.Y.Z`. - Minor-pinned versions (e.g., `X.Y` or `~> X.Y`) are changed to `~> X.Y.0`. - Patch-pinned optimistic versions (e.g., `~> X.Y.Z`) remain unchanged.
@@ -37,29 +37,29 @@ Pod::Spec.new do |s| | |||
s.default_subspecs = 'Default' | |||
|
|||
s.subspec 'Default' do |ss| | |||
ss.dependency 'GoogleAppMeasurement/Default', '12.0.0' | |||
ss.dependency 'GoogleAppMeasurement/Default', '~> 12.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GoogleAppMeasurement and FirebaseAnalytics should be locked together and always released together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And below
@@ -37,8 +37,8 @@ Pod::Spec.new do |s| | |||
s.default_subspecs = 'Default' | |||
|
|||
s.subspec 'Default' do |ss| | |||
ss.dependency 'GoogleAppMeasurement/Core', '12.0.0' | |||
ss.dependency 'GoogleAppMeasurement/IdentitySupport', '12.0.0' | |||
ss.dependency 'GoogleAppMeasurement/Core', '~> 12.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert this file also
This change updates all internal podspec dependencies to use strict versioning, pinned to the patch version.
~>
) are changed to strict versions (e.g.,~> 12.0.0
to12.0.0
).12.0
) are changed to pin to the patch version (e.g.,12.0
to12.0.0
).This ensures that the build process uses exact versions of internal dependencies, preventing potential compatibility issues and providing more precise version control.