Skip to content

[Infra] Use strict patch versions for internal podspec dependencies #15049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 27, 2025

This change updates all internal podspec dependencies to use strict versioning, pinned to the patch version.

  • Dependencies using optimistic versioning (~>) are changed to strict versions (e.g., ~> 12.0.0 to 12.0.0).
  • Dependencies already using exact versions pinned to the minor (e.g., 12.0) are changed to pin to the patch version (e.g., 12.0 to 12.0.0).

This ensures that the build process uses exact versions of internal dependencies, preventing potential compatibility issues and providing more precise version control.

This change updates all internal podspec dependencies to use strict versioning, pinned to the patch version.

- Dependencies using optimistic versioning (`~>`) are changed to strict versions (e.g., `~> 12.0.0` to `12.0.0`).
- Dependencies already using exact versions pinned to the minor (e.g., `12.0`) are changed to pin to the patch version (e.g., `12.0` to `12.0.0`).

This ensures that the build process uses exact versions of internal dependencies, preventing potential compatibility issues and providing more precise version control.
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

This change updates all internal podspec dependencies to float to the patch version (e.g., `~> X.Y.Z`).

This allows for more flexibility in patch releases while maintaining stability for minor and major versions, as discussed in the PR feedback.

- Strict versions (e.g., `X.Y.Z`) are changed to `~> X.Y.Z`.
- Minor-pinned versions (e.g., `X.Y` or `~> X.Y`) are changed to `~> X.Y.0`.
- Patch-pinned optimistic versions (e.g., `~> X.Y.Z`) remain unchanged.
@ncooke3 ncooke3 added this to the Firebase 12 - M167 milestone Jun 27, 2025
@@ -37,29 +37,29 @@ Pod::Spec.new do |s|
s.default_subspecs = 'Default'

s.subspec 'Default' do |ss|
ss.dependency 'GoogleAppMeasurement/Default', '12.0.0'
ss.dependency 'GoogleAppMeasurement/Default', '~> 12.0.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GoogleAppMeasurement and FirebaseAnalytics should be locked together and always released together

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And below

@@ -37,8 +37,8 @@ Pod::Spec.new do |s|
s.default_subspecs = 'Default'

s.subspec 'Default' do |ss|
ss.dependency 'GoogleAppMeasurement/Core', '12.0.0'
ss.dependency 'GoogleAppMeasurement/IdentitySupport', '12.0.0'
ss.dependency 'GoogleAppMeasurement/Core', '~> 12.0.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this file also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants