Forms: prevent unauthenticated users from pasting images #20224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trasher
approved these changes
Jul 7, 2025
cedric-anne
requested changes
Jul 7, 2025
| @@ -329,7 +329,7 @@ private function applyPredefinedTemplateFields(array $input): array | |||
| /** @var \CommonITILObject $itil */ | |||
| $itil = new $itemtype(); | |||
| $template = $itil->getITILTemplateToUse( | |||
| entities_id: $_SESSION["glpiactive_entity"], | |||
| entities_id: $_SESSION["glpiactive_entity"] ?? 0, | |||
There was a problem hiding this comment.
The template should be fetched from the target entity (it is configurable in forms).
There was a problem hiding this comment.
Should probably have been another PR, but I've fixed it.
cedric-anne
reviewed
Jul 7, 2025
src/Glpi/Form/Destination/AbstractCommonITILFormDestination.php
Outdated
Show resolved
Hide resolved
cedric-anne
approved these changes
Jul 7, 2025
|
Please fix tests |
cedric-anne
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
For unauthenticated forms, disable the
enable_imagessettings for textarea questions.