External Editor line flag differs in behavior from internal editor

[bvnanana]

Tested versions

• Tested in Godot v4.3.stable.official [77dcf97]
• Reproducible in both VSCode and SublimeText
• Unsure if it applies to any other editor

System information

Godot v4.3.stable - Windows 10.0.19045 - GLES3 (Compatibility) - AMD Radeon(TM) Vega 8 Graphics (Advanced Micro Devices, Inc.; 31.0.12027.9001) - AMD Ryzen 3 3200G with Radeon Vega Graphics (4 Threads)

Issue description

When using a external editor, files open 1 line before the expected line while debugging. Compare:

This happens with the official VSCode settings as well, which is why I tried a different one here.

I'm unfamiliar with how this works internally, but this seems to be the line that replaces the flag for the external editor:

godot/editor/plugins/script_editor_plugin.cpp

Line 2508 in 99a8ab7

flags = flags.replacen("{line}", itos(p_line > 0 ? p_line : 0));

And I found this case where it is being modified:

godot/editor/plugins/script_editor_plugin.cpp

Line 617 in 99a8ab7

EditorDebuggerNode::get_singleton()->set_breakpoint(scr->get_path(), p_line + 1, p_enabled);

It didn't seem like it was possible to modify the line flag directly in the editor settings in way (like adding a +1)

Steps to reproduce

• Configure a project with an external editor, like VSCode
• Use External Editor for Debugging
• insert a breakpoint at any line
• see the wrong line being open

Minimal reproduction project (MRP)

N/A

[CreatedBySeb]

Still reproducible on v4.5.dev.custom_build [215acd52e]. From a quick debug, it looks like the issue may be related to the fact that lines in the script editor seem to be internally zero-indexed, while line numbers passed to external editors are typically one-indexed, since when I put a breakpoint in ScriptEditor::edit I can see p_line is the line number before the breakpoint. Unsure why this would only show up in this place though and not everywhere an external editor is opened, since there doesn't seem to be any handling for this in this function, unless there is handling further up the call stack in other places.

Godot v4.5.dev (215acd52e) - Pop!_OS 22.04 LTS on X11 - X11 display driver, Multi-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (nvidia; 570.133.07) - AMD Ryzen 7 3700X 8-Core Processor (16 threads)

cc @AThousandShips