Weblate's Translation Browser link template is invalid/(outdated?)

[juliancoffee]

Tested versions

https://hosted.weblate.org/projects/godot-engine/

System information

I don't think that's needed

Issue description

Well, there's a feature in Weblate called Repository browser.
It's set per Component, but I see that two of your components are linked to Godot Properties (and I assume Godot Documentation lives somewhere else).

If you're on the component's page, go to Manage>Settings>Version Control and you'll find it.
I believe yours is set to something like:

https://github.com/godotengine/godot/blob/{{branch}}//{{filename}}#L{{line}}

It probably should be something along the lines of:

https://github.com/godotengine/godot/blob/{{branch}}/editor/translations/{{filename}}#L{{line}}

Although to be fair, I agree that it is a bit weird that Weblate can't properly specify the filename 🤔
Maybe it got kinda borked when components where moved around in the source, in which case it might be a Weblate bug.

Steps to reproduce

1. Go to the unit's page, like this one: https://hosted.weblate.org/translate/godot-engine/godot/en/?q=
2. Check out the last line in the String information, it's a clickable link (editor/editor/pot)

3. Click the link
4. Observe Github's 404 page

Minimal reproduction project (MRP)

None, I was just randomly browsing projects on hosted Weblate, and found this 😅

[akien-mga]

Thanks for the report.

I looked at the settings and I think we can't solve this problem with Weblate currently.

The setting for this is:

https://github.com/godotengine/godot/tree/master/{{filename}}#L{{line}}

And that's what is correct for the "Source string location":

But Weblate reuses the same setting for the "Translation file" link, which doesn't work in our case as the translation files live in a separate repo:

https://github.com/godotengine/godot-editor-l10n/tree/main/editor

The reason for this split is that there's a lot of diff noise on translation updates, and we only want to copy the "final" data ready to use in production in the main engine repo.

For each resource, we have a customer threshold for what should be exported to the engine repo, and we even strip empty or fuzzy translations to reduce the diff size:
https://github.com/godotengine/godot-editor-l10n/blob/main/editor/Makefile#L24-L43

So to solve this we'd need a new feature implemented in Weblate to have separate settings for source string location repository and translation file repository.

It's a relatively niche use case so I'm not sure I'd want to bother them with that.

[timothyqiu]

I submitted this last year: WeblateOrg/weblate#12308

[akien-mga]

Closing then as we can't fix it for now. If the upstream issue is resolved, but @timothyqiu and I should be notified so we'll make sure to update the Weblate settings.