Image thumbnails in FileSystem distorted

[awkr]

Godot version:

v3.2.3.stable.official

OS/device including version:

macOS Catalina 10.15.7

Issue description:

Image assets containing text menu in the official tutorial, when imported to Godot, they look like this:

I believe neat, elegant UI will makes you guys more efficiency.

Minimal reproduction project:

MainMenuDesign.zip

[Calinou]

I can confirm this on 3.2.4beta1 on Linux:

The issue isn't specific to hiDPI displays.

[lawnjelly]

Is this referring to the aspect ratio or the filtering (or both)? (I'm guessing aspect ratio?)

[Calinou]

@lawnjelly Probably the aspect ratio.

[mbrlabs]

I looked into this a bit and found that the small preview thumbnails are always generated with the same height and width:

godot/editor/editor_resource_preview.cpp

Lines 176 to 182 in be14d9d

	if (!r_small_texture.is_valid() && r_texture.is_valid() && preview_generators[i]->generate_small_preview_automatically()) {
	Ref<Image> small_image = r_texture->get_data();
	small_image = small_image->duplicate();
	small_image->resize(small_thumbnail_size, small_thumbnail_size, Image::INTERPOLATE_CUBIC);
	r_small_texture.instance();
	r_small_texture->create_from_image(small_image);
	}

On my system small_thumbnail_size is 16. If i scale the preview thumbnails in a way that they preserve their aspect ratio it looks like this (sadly not really an improvement):

I'm not sure what can be done about this except making the tumbnails bigger, which also sucks.

[lawnjelly]

It does look marginally better to my eyes with correct aspect ratio, but there is less info conveyed.

What I have done in previous apps with this problem, is use a tooltip. When you hover over the item, it shows a larger thumbnail. This might take a bit of rejigging to achieve, but is an option.