Fix MeshInstance3D::get_active_material() error on empty mesh or empty surfaces
#107691
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y surfaces FixesMeshInstance3D::get_active_material() error on empty mesh or empty surfaces.
AThousandShips
added
the
cherrypick:4.4
clayjohn
approved these changes
Jun 23, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105580
A
MeshInstance3Dwithout aMeshresource (or empty surfaces) has also empty surface material arrays.The
get_active_material()function tried to access those empty internal material arrays and did run into index errors.The correct order for checking what material is active is:
GeometryInstance3D.Mesheven exists and if it has surfaces.