Add missing vpv.push_back(pv); in render_target_get_sdf_texture.
#107763
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3889,7 +3889,7 @@ RID TextureStorage::render_target_get_sdf_texture(RID p_render_target) { | |||
| pv.resize(16 * 4); | |||
| memset(pv.ptrw(), 0, 16 * 4); | |||
| Vector<Vector<uint8_t>> vpv; | |||
|
|
|||
| vpv.push_back(pv); | |||
There was a problem hiding this comment.
Can't this just be replaced with:
Vector<Vector<uint8_t>> vpv = { pv };There was a problem hiding this comment.
Also possible, I just copied the style of all the other vpv parts in this file to stay agnostic.
There was a problem hiding this comment.
(Also, initializer_list makes an unnecessary Vector copy, see godotengine/godot-proposals#12247)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the context, this looks like it was intended.
The alternative would be not creating
pvorvpv, instead defaulting to empty.I'm not sure what the difference will be; at the very least it should now check for the size requirements.
Code came from #59984