Skip to content

Improve editor settings override display #107765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jun 20, 2025

Follow-up to #69012
Changes the layout of override display to better use available space and fixes property hints for override display.

Before:
image
After:
image

@KoBeWi KoBeWi added this to the 4.x milestone Jun 20, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner June 20, 2025 13:12
@Mickeon Mickeon requested a review from kitbdev June 24, 2025 15:01
@Mickeon
Copy link
Member

Mickeon commented Jun 24, 2025

Is it not possible to have these align horizontally?
image

@KoBeWi KoBeWi changed the title Improve editor settings overlay display Improve editor settings override display Jun 24, 2025
@KoBeWi
Copy link
Member Author

KoBeWi commented Jun 24, 2025

Unfortunately it's not that easy. They are 2 separate EditorProperties. There is a way to control the name split ratio, but making them line up will be tricky.

@Mickeon
Copy link
Member

Mickeon commented Jun 24, 2025

It makes me so mad. Perhaps it would be possible to move the "Cross" button to the left instead?

@KoBeWi
Copy link
Member Author

KoBeWi commented Jun 24, 2025

It's possible. Where exactly? And what about the blue arrow?

@Mickeon
Copy link
Member

Mickeon commented Jun 24, 2025

Mock-up in the hopes of not overflowing the property field to the left, at least
image

And what about the blue arrow?

Shrug

@KoBeWi
Copy link
Member Author

KoBeWi commented Jun 24, 2025

Ah no, that's not possible, at least not simple. The name and value are one node.

Copy link
Member

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the above, this is still an improvement compared to the current look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants