Fix baked VoxelGI using the wrong color space #107776
Merged
+14
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
reviewed
Jun 24, 2025
clayjohn
approved these changes
Jun 24, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes baked voxelGI having washed-out colors because it was using sRGB textures/colors without converting them to linear.
example from this test scene #63374 comparing this PR to blender
note that dynamic voxelGI did not have this issue, so this brings baked voxelGI in line with dynamic.
this slightly helps #64125, because the emission brightness multiplier was being applied to washed out colors which artificially increased the brightness of baked GI, but this isn't a complete fix for that issue, since baked GI is still much brighter.