Replace iOS/visionOS Xcode templates by new Apple embedded template #107789
+609
−1,193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pple embedded template
stuartcarnie
approved these changes
Jun 21, 2025
There was a problem hiding this comment.
Great work, @rsanchezsaez – always nice when there is less code for the same functionality 👏🏻 💯
|
I don't think I can offer much input here that @bruvzg and @stuartcarnie don't have a far more informed opinion on. I'm all for improving unifying this code as it will make future maintenance easier, and this looks like excellent work. |
bruvzg
approved these changes
Jun 25, 2025
|
@bruvzg Thank you for the review! Build scripts PR: godotengine/godot-build-scripts#121 |
Comment on lines
+385
to
+386
| for (int i = 0; i < cs.size() - 1; i++) { | ||
| p_file.write[i] = cs[i]; |
There was a problem hiding this comment.
Suggested change
| for (int i = 0; i < cs.size() - 1; i++) { | |
| p_file.write[i] = cs[i]; | |
| uint8_t *p_file_ptrw = p_file.ptrw(); | |
| for (int i = 0; i < cs.size() - 1; i++) { | |
| p_file_ptrw[i] = cs[i]; |
Comment on lines
+447
to
+449
| if (uuid.is_empty()) { | ||
| uuid = ""; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (uuid.is_empty()) { | |
| uuid = ""; | |
| } |
This does nothing (was this a mistake?)
| rel_manual |= valid_rel_specifier; | ||
|
|
||
| String str = String::utf8((const char *)pfile.ptr(), pfile.size()); | ||
| String str = String::utf8((const char *)p_file.ptr(), p_file.size()); | ||
| String strnew; | ||
| Vector<String> lines = str.split("\n"); | ||
| for (int i = 0; i < lines.size(); i++) { |
There was a problem hiding this comment.
Suggested change
| for (int i = 0; i < lines.size(); i++) { | |
| for (const String &line : lines) { |
| entitlements += "<key>com.apple.developer.kernel.increased-memory-limit</key>\n<true/>\n"; | ||
| } | ||
| entitlements += p_preset->get("entitlements/additional").operator String() + "\n"; | ||
| strnew += _process_config_file_line(p_preset, lines[i], p_config, p_debug, code_signing); |
There was a problem hiding this comment.
Suggested change
| strnew += _process_config_file_line(p_preset, lines[i], p_config, p_debug, code_signing); | |
| strnew += _process_config_file_line(p_preset, line, p_config, p_debug, code_signing); |
Comment on lines
+512
to
+513
| for (int idx = 0; idx < capabilities_list.size(); idx++) { | ||
| capabilities += "<string>" + capabilities_list[idx] + "</string>\n"; |
There was a problem hiding this comment.
Suggested change
| for (int idx = 0; idx < capabilities_list.size(); idx++) { | |
| capabilities += "<string>" + capabilities_list[idx] + "</string>\n"; | |
| for (const String &capability : capabilities_list) { | |
| capabilities += "<string>" + capability + "</string>\n"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is builds on #105628 by unifying the iOS and visionOS Xcode project template files into a new Apple embedded Xcode project template.
The templates were largely identical, with a few set of small changes between them.
The new
EditorExportPlatformAppleEmbedded::_process_config_file_line()function has been overridden on the iOS and visionOS export plugins to provide the specific values needed for each platform.I verified that the iOS and visionOS templates continue to build successfully, and have successfully exported and run the
platformersample for both platforms.(I suggest we target this to 4.6, no need to risk a regression in 4.5 while in beta.)
cc @stuartcarnie @bruvzg