Skip to content

Fix stencil preset next_pass stencil flags #107808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

apples
Copy link
Contributor

@apples apples commented Jun 21, 2025

The stencil outline and x-ray presets were incorrectly using read+write stencil flags in their next_pass material.

Since materials normally cannot have both read and write stencil flags, the write flag would immediately get unset if the flags were poked at all.

This PR changes the preset next_pass materials to read only, and ensures that existing materials with read+write flags are correctly loaded with only the read flag set.

Related: #107767

@akien-mga akien-mga changed the title Fix stencil preset next_pass stencil flags Fix stencil preset next_pass stencil flags Jun 21, 2025
@akien-mga akien-mga merged commit 8450eb2 into godotengine:master Jun 22, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@apples apples deleted the apples-stencil-preset-readwrite-fix branch June 22, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants