Use one-based line numbers for external text editors #107816
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbdev
reviewed
Jun 21, 2025
There was a problem hiding this comment.
The column should also be 1 indexed.
We can't completely change to a 1 index system internally in the future, it would just cause lots of issues. The lines are stored in a vector which is always going to be 0 indexed, and it would cause compatibility issues if we change TextEdit and CodeEdit methods to be 1 indexed as well. I also doubt those editors all actually use 1 indexed internally, its just the interface.
So there is always going to be conversion between them, we just need to better define where it happens.
We already display line numbers in the editor as starting from 1, and EditorInterface::edit_script looks like it is already 1 indexed.
Meorge
force-pushed
the
bugfix/everyone-uses-one-based-line-numbers
branch
from
3162399 to
5c94b2e
Compare
kitbdev
approved these changes
Jun 24, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107809 . Closes #100832 . Supercedes #107812 .
The table in #107809 notes that all of the external editors mentioned by the Godot Docs expect line numbers to start at 1. Internally, Godot considers line numbers to start at 0. This PR simply adds 1 to an existing line number before passing it to an external editor, so that the editor highlights the correct line.
As noted in the PR's comment, a better long-term solution may be to have Godot adopt one-based line numbering internally. I chose to take a more conservative approach for now, to avoid breaking other parts of the engine or editor while fixing the problem at hand.