Fix: Tilemap tools not overriding main editor tools

[DexterFstone]

Closes godotengine/godot-proposals#12646

[groud]

Removed the "bug" label as this is the intended behavior.

I am not sure about this change, I'd like the proposal to be backed a bit more, as the other tools can be useful even if the TileMap editor is visible. Those other tools are more specific than the "select" one, which make me think when you change to them, then you know what you are doing and expect them to work right away.

[DexterFstone]

I am not sure about this change, I'd like the proposal to be backed a bit more, as the other tools can be useful even if the TileMap editor is visible. Those other tools are more specific than the "select" one, which make me think when you change to them, then you know what you are doing and expect them to work right away.

The scenario I was considering was this:
The user has selected a tool other than the select tool
Now the user selects the TileMapLayer node and wants to start painting with the default tool, but since the selection tool is not a select, it is having trouble
I think the best place to edit the tool selection was when the TileMapEditor is displayed
After that, if needed, the user can select their own tool, such as rotate or scale

[groud]

hmm. I guess it makes sense then. If it still allows you to use the tools afterward I guess it could work.

I wonder if it's still good though, there might be some users who you like, for example, the "move" tool to stay active when selecting nodes one after the other in the scene tree. And the fact we would introduce this new behavior (about selecting a node possibly auto-switching the tool) might be a bit confusing and annoying for some.

That being said, switching to select mode when clicking a tool in the tilemap bottom toolbar makes perfect sense. I think it might deserve either a dedicated function though, or simply _update_toolbar to be renamed to something like _tool_button_pressed (so that's it's a bit clearer it does now more than update the toolbar).

[DexterFstone]

I updated the code, now it should be cleaner and work better. Additionally, it keeps track of the previously selected tool, so whenever TileMapLayerEditor is unavailable, the tool will revert to its original state.

• When selecting TileMapLayer, it forces the CanvasItemEditor to select the Select tool.
• When the mouse enters the TileMapLayerEditor, it forces the CanvasItemEditor to select the Select tool.
• When selecting the TileMapLayerEditor tools, it forces the CanvasItemEditor to select the Select tool.
• When deselecting the TileMapLayer, it forces the CanvasItemEditor to revert to the previous tool.

Note

In my tests, the mouse entered does not always work