Fix Resource doesn't update when overwritten in editor #107850
Merged
+11
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #30302, #104966 (comment)
After this PR, resources overwritten by
EditorNode::save_resource_in_path
can be updated in scenes, inspector and thumbnails correctly.Note:
Resources in the scene are still not be updated, but they can be updated by re-assigning the resources or reloading the scene.Resolved byEditorNode::replace_resources_in_scenes
.Resource.take_over_path
andEditorFileSystem.update_file
. However it has the above issue unless reloading resources in the scene.