Skip to content

Fix Resource doesn't update when overwritten in editor #107850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

beicause
Copy link
Contributor

@beicause beicause commented Jun 22, 2025

Partially addresses #30302, #104966 (comment)

After this PR, resources overwritten by EditorNode::save_resource_in_path can be updated in scenes, inspector and thumbnails correctly.

Note:

  • Resources in the scene are still not be updated, but they can be updated by re-assigning the resources or reloading the scene. Resolved by EditorNode::replace_resources_in_scenes.
  • Resources overwritten by tool scripts are still not updated, but this may be resolved by manually calling Resource.take_over_path and EditorFileSystem.update_file. However it has the above issue unless reloading resources in the scene.

@beicause beicause requested review from a team as code owners June 22, 2025 14:21
@beicause beicause force-pushed the Fix-Resource-doesn't-update-when-overwritten-in-editor branch 2 times, most recently from bd3df80 to ccfeacb Compare June 22, 2025 14:59
@AThousandShips AThousandShips added bug topic:editor cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Jun 23, 2025
@AThousandShips AThousandShips added this to the 4.5 milestone Jun 23, 2025
@beicause beicause force-pushed the Fix-Resource-doesn't-update-when-overwritten-in-editor branch from ccfeacb to 8e7b80d Compare June 28, 2025 16:18
@beicause beicause force-pushed the Fix-Resource-doesn't-update-when-overwritten-in-editor branch from 8e7b80d to 0c74c09 Compare June 28, 2025 17:09
@Repiteo Repiteo merged commit 639c41d into godotengine:master Jul 1, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jul 1, 2025

Thanks!

@beicause beicause deleted the Fix-Resource-doesn't-update-when-overwritten-in-editor branch July 2, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release topic:editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants