[3.x] Scons - add compiler requirements
#107851
Merged
+207
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
lawnjelly
commented
Jun 22, 2025
lawnjelly
force-pushed
the
scons_check_compiler_version
branch
2 times, most recently
from
9457940 to
50f1995
Compare
Repiteo
requested changes
Jun 25, 2025
lawnjelly
force-pushed
the
scons_check_compiler_version
branch
from
50f1995 to
4aa8ecd
Compare
Repiteo
approved these changes
Jun 26, 2025
|
Great! 👍 I'll leave merging this and the c++17 until after Remi has gone on holiday, just in case we want to build 3.7 alpha 1 before then, in case it affects the build in any unexpected way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my (nOOb) attempt at backporting some of the compiler checks we use in 4.x for c++17.
The new
get_compiler_version()returns a dictionary with more info, so in the interests of not breaking the existingSConstructI've renamed itget_compiler_version_ex().It seems to pass CI (by some miracle! 😁 ) but could do with a check by @Repiteo / @akien-mga .
To be used in conjunction with #107847.