Editor: Update inspector group toggles visually #107857
Open
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, properties using PROPERTY_HINT_GROUP_ENABLE for inspector sections do not update their visual state (checkbox and folding) immediately when changed by external scripts (e.g., @tool scripts). This is because these properties do not create an EditorProperty instance, thus bypassing the standard update mechanism based on �ditor_property_map. This commit introduces a new _toggle_sections HashMap in EditorInspector to specifically track and update these sections. When a property change is requested or during auto-refresh, if the property is a section toggle, its associated EditorInspectorSection will now be updated directly.
AThousandShips
changed the title
|
tá travando |
|
@PedroPLopes1 The official language of these channels is English, please make any reports or comments in English, if you do not know English please use some translation software or ask for help. |
Eu peço desculpas. Translation: I ask excuses. |
|
Sorry, I just saw this PR. This is also fixed by #107919 by necessity, I'm more in favor of that PR (it uses a pre-existing list rather than creating a new one) but I'll let maintainers decide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, properties using
PROPERTY_HINT_GROUP_ENABLEfor inspector sections do not update their visual state (checkbox and folding) immediately when changed by external scripts (e.g.,@toolscripts). This is because these properties do not create an EditorProperty instance, thus bypassing the standard update mechanism based oneditor_property_map.This commit introduces a new
_toggle_sectionsHashMap inEditorInspectorto specifically track and update these sections. When a property change is requested or during auto-refresh, if the property is a section toggle, its associatedEditorInspectorSectionwill now be updated directly.Fixes: #107826