Skip to content

Don't mark the project unsaved when loading editor plugins in initial session #107884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't mark the project unsaved when loading editor plugins in initial session #107884

wants to merge 1 commit into from
+17 −14

Conversation

exyxz
Copy link
Contributor

@exyxz exyxz commented Jun 23, 2025

Fixes #107883

This PR fixes it by using EditorFileSystem::get_singleton()->doing_first_scan() as a check for EditorAutoloadSettings::autoload_add function.

Should be cherry-pickable for 4.4.

@AThousandShips AThousandShips added bug topic:editor cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Jun 23, 2025
@AThousandShips AThousandShips requested a review from a team June 23, 2025 08:54
@AThousandShips AThousandShips added this to the 4.5 milestone Jun 23, 2025
@exyxz exyxz mentioned this pull request Jun 23, 2025
Open
@KoBeWi
Copy link
Member

KoBeWi commented Jun 24, 2025

The project from the issue still becomes unsaved.

@exyxz
Copy link
Contributor Author

exyxz commented Jun 24, 2025 •
edited
Loading

The project from the issue still becomes unsaved.

Did you tested with the PR?
If so, there may be other functions i wasn't aware of.

@KoBeWi
Copy link
Member

KoBeWi commented Jun 24, 2025

Did you tested with the PR?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release topic:editor
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

The project was considered unsaved when loading editor plugins initially.
3 participants
@exyxz @KoBeWi @AThousandShips