Fix animation keying not working with toggleable inspector sections #107919
+136
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodetrick
force-pushed
the
toggle-section-key
branch
3 times, most recently
from
db89868 to
d7405ac
Compare
lodetrick
force-pushed
the
toggle-section-key
branch
4 times, most recently
from
75a8ded to
2aaf33f
Compare
Calinou
approved these changes
Jun 28, 2025
lodetrick
force-pushed
the
toggle-section-key
branch
from
2aaf33f to
f2233b3
Compare
|
I just pushed a fix that allows the "favorited" sections to update properly, I just added the relevant ones to the It was two lines of code, 4492 and 4532 |
KoBeWi
reviewed
Jun 30, 2025
KoBeWi
reviewed
Jun 30, 2025
lodetrick
force-pushed
the
toggle-section-key
branch
from
f2233b3 to
5443fe9
Compare
|
I resolved the comments and adapted the folding code to handle the fact that toggleable sections can now be not foldable (since the sections in favorites were added to sections which meant that fold and unfold were called on them) |
KoBeWi
approved these changes
Jul 3, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107891 Closes #107826
Supersedes #107857
This PR adds the animation keying button to toggleable sections. This also allows the buttons to update over time in order to accommodate how the animation editor edits the values.