Skip to content

Mark GDScript and shader warnings for translation #107944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jun 24, 2025

Resolves #107505

@KoBeWi KoBeWi added this to the 4.x milestone Jun 24, 2025
@KoBeWi KoBeWi requested review from a team as code owners June 24, 2025 16:04
@akien-mga akien-mga requested a review from timothyqiu June 24, 2025 16:37
m4gr3d
m4gr3d previously requested changes Jun 24, 2025
@KoBeWi KoBeWi force-pushed the PNAMING_everything branch from a978ef8 to 9b0d73a Compare June 24, 2025 18:05
@KoBeWi
Copy link
Member Author

KoBeWi commented Jun 24, 2025

Removed Android changes. We don't have a way to disable humanized names for only some properties in the inspector, I think it could be achieved with a new hint.

@KoBeWi KoBeWi force-pushed the PNAMING_everything branch from 9b0d73a to 601e5f0 Compare June 24, 2025 18:08
@KoBeWi KoBeWi changed the title Mark warnings and Android permissions for translation Mark GDScript warnings for translation Jun 24, 2025
@KoBeWi KoBeWi force-pushed the PNAMING_everything branch from 601e5f0 to c35bc51 Compare June 24, 2025 19:52
@KoBeWi KoBeWi force-pushed the PNAMING_everything branch from c35bc51 to b612cb8 Compare June 24, 2025 20:41
@KoBeWi KoBeWi requested a review from a team as a code owner June 24, 2025 20:41
@akien-mga
Copy link
Member

In #107505 there are also Shader language warnings which seem not to be translated, I assume they can get the same treatment?

@KoBeWi KoBeWi force-pushed the PNAMING_everything branch from b612cb8 to 015cc38 Compare June 24, 2025 21:12
@KoBeWi KoBeWi requested a review from a team as a code owner June 24, 2025 21:12
@KoBeWi KoBeWi changed the title Mark GDScript warnings for translation Mark GDScript and shader warnings for translation Jun 24, 2025
@akien-mga akien-mga modified the milestones: 4.x, 4.5 Jun 24, 2025
@Repiteo Repiteo merged commit 5b01921 into godotengine:master Jun 24, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 24, 2025

Thanks!

@KoBeWi KoBeWi deleted the PNAMING_everything branch June 24, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some project settings and export preset settings can't be localized (GDScript and shader warnings, Android export permissions)
5 participants