[Web] Fix Webkit leak caused by the position reporting audio worklets #107948
+20
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces the pooling of
GodotPositionReportingProcessor
worklets. This is because Webkit doesn't seem to delete processors that returnfalse
inprocess()
, even if the specs says to do so. That made the memory explode and the Webkit engine reloading the games.This PR also removes the
postMessage
limit on audio position worklet. The tests made by @PizzaLovers007 seem to indicate that the partial reporting didn't achieve it's goals and was basically useless.Here's my iPad Pro M3 running a tweaked version of the #107390 MRP for more than 18 minutes straight.
At the 18 minutes mark, nothing seems to indicate that the MRP was taxing for my iPad, memory-wise nor processing-wise.
MRP: audio-test.zip
Fixes #107390.
Fixes #105397.
Supersedes #105541. (added co-authorship)
Reverts the spirit of #102715.
Doesn't seem to create a regression for #102505.