Sync controller mappings DB with SDL community repo #107962
Merged
+177
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
|
I think an argument can be made that this is a bugfix. Personally, I'd like this to be included in 4.5, I think it goes hand in hand with the inclusion of SDL v3. IMHO, people are going to expect outstanding issues with controllers fixed by this move and may be disappointed if that's not the case. It may also add support for newer controllers from 8bitdo, Nintendo (switch 2), Hori, etc. |
|
Previous updates to this have been marked as enhancements, simply following that pattern |
|
Could you update the commit message to clarify which commit of SDL_GameControllerDB you're syncing with? See how it's done usually: #91108. |
geowarin
force-pushed
the
update-controller-db
branch
from
2f24962 to
9b455aa
Compare
geowarin
force-pushed
the
update-controller-db
branch
from
9b455aa to
88c086d
Compare
AThousandShips
changed the title
akien-mga
approved these changes
Jun 25, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synced with: mdqinc/SDL_GameControllerDB@1849728
After #106218 was merged, I was surprised that my DualSense Edge controller still wouldn't work properly under linux.
Turns out updating gamecontrollerdb.txt fixes the problem.
It looks like it wasn't updated for a while.
I'm not very familiar with this, shouldn't this be updated regularly?
Maybe updating gamecontrollerdb.txt can be included in the script that updates the SDL code?