Fix CodeEdit setter/getter types #107968
Open
Fix CodeEdit setter/getter types #107968
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But will that impact my changes? Should I redo my PR based on that one? |
|
You might need to rebase to fix conflicts, depending on which PR gets merged first. It should only affect the type hints, which are no longer necessary (as I mentioned in #107529 (comment)). |
KoBeWi
force-pushed
the
packed_typed_array
branch
from
e1a9212 to
ce566e5
Compare
|
It looks like this will need compatibility binds. |
KoBeWi
force-pushed
the
packed_typed_array
branch
from
ce566e5 to
e7a6cf4
Compare
|
So apparently changing setters/getters influences the type reported in the documentation. Maybe I should instead change the declared type of the properties? |
|
Regardless of what you do, changing the exposed type does break compatibility. |
KoBeWi
force-pushed
the
packed_typed_array
branch
from
e7a6cf4 to
004aa1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #107529
CodeEdit defined its properties as PackedArrays, but the setters and getters were using TypedArray instead. I changed it all to properly use PackedArrays.