Fix VVL errors by changing frag_color to FP32 and dFdx/y.
#108015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just tested with that PR, but, unfortunately, the same VVL errors are there |
dsnopek
approved these changes
Jun 26, 2025
akien-mga
changed the title
frag_color to FP32 and dFdx/y.
clayjohn
approved these changes
Jun 26, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #108009.
Mostly a continuation of the fix applied in #107419, although this is only because of the VVL and not because we've seen any driver break with it.
I don't have a solid confirmation as to why dFdx/dFdy would fail to generate valid code when used with FP16 vectors and whether this is a glslang error or something we're just supposed to work around. It might be best to test #107773 first and confirm if the error doesn't appear.