Skip to content

Backport of Service Health Status in Endpoints Controller Logs into release/1.7.x #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/1.7.x
Choose a base branch
from

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #4616 to be assessed for backporting due to the inclusion of the label backport/1.7.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@kswap
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "dbd7d8c9dab1ffa8dcf0302c61ce8396f764b35b", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Changes proposed in this PR

This PR includes the health status of the service being registered/updated by the endpoints controller.

This helps identify the service health state transitions, which are currently impossible and impact the ability to troubleshoot issues.

How I've tested this PR

  • Created a custom binary and used it in a Kubernetes cluster. Updates the logging to look like the below. Notice the health field in the logging.
INFO    controller.endpoints    retrieved       {"name": "nginx", "ns": "default"}
INFO    controller.endpoints    registering service with Consul {"name": "nginx", "id": "nginx-nginx", "health": "critical"}
INFO    controller.endpoints    adding manual ip to virtual ip table in Consul  {"name": "nginx", "id": ""}
INFO    controller.endpoints    registering proxy service with Consul   {"name": "nginx-sidecar-proxy", "id": "nginx-nginx-sidecar-proxy", "health": "critical"}
INFO    controller.endpoints    retrieved       {"name": "nginx", "ns": "default"}
INFO    controller.endpoints    registering service with Consul {"name": "nginx", "id": "nginx-nginx", "health": "passing"}
INFO    controller.endpoints    adding manual ip to virtual ip table in Consul  {"name": "nginx", "id": ""}
INFO    controller.endpoints    registering proxy service with Consul   {"name": "nginx-sidecar-proxy", "id": "nginx-nginx-sidecar-proxy", "health": "passing"}

Checklist


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/feature/include-svc-reg-health-status/marginally-exact-macaw branch from 5d66332 to 5c093eb Compare June 24, 2025 06:00
@sujay-hashicorp sujay-hashicorp marked this pull request as ready for review June 25, 2025 05:47
@sujay-hashicorp sujay-hashicorp requested a review from a team as a code owner June 25, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants