-
Notifications
You must be signed in to change notification settings - Fork 718
Fix parsing AbiTag for development compilers #10979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
84c4bf9
to
197a397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a little part of my hindbrain that thinks stripCommon
should be in a where
unless it's going to be used somewhere else as well, in which case it should be moved somewhere common.
I get you. I would be happy to move it somewhere else if you have a suitable location in mind. I agree that it feels like more of a general utility |
I think someone with a better understanding of the source organization will have to weigh in on that; I'm still learning. (To date I just do reviews and work on CI, and am slowly making my way through the source from an operational standpoint (e.g. understanding IPI, LBI, etc.) |
9ec3b21
to
c8e54ed
Compare
In general, the unit-id of the A unit-id can be anything but is prefixed by pkg/version by convention, on darwin systems the package names do not contain vowels for example. That's something to keep in mind for future, but at least this is an improvement for now. |
When using a development compiler the compilerId isn't a prefix of the Project Unit Id. This led to a failure to parse the AbiTag. We extend the parsing logic to handle these cases by only removing the common prefix and then any leading '-'s. Resolves #10170
c8e54ed
to
633c83e
Compare
When using a development compiler the compilerId isn't a prefix of the Project Unit Id. This led to a failure to parse the AbiTag.
We extend the parsing logic to handle these cases by only removing the common prefix and then any leading '-'s.
Resolves #10170
Manual QA notes
To test this try using cabal-install with a development version of the compiler, and check that the AbiTag is actually parsed. (I did this with traces locally)
Include the following checklist in your PR:
significance: significant
in the changelog file.