Skip to content

intset-benchmarks no longer build on windows. #885

New issue
New issue
Open
#886
Open
intset-benchmarks no longer build on windows.#885
#886
Labels
maintainability
@AndreasPK

Description

@AndreasPK
AndreasPK
opened on Dec 23, 2022
Contributor

On commit 468aa9d I get this after a checkout and running cabal run intset-benchmarks I get this error:

cabal run intset-benchmarks
Build profile: -w ghc-9.4.2 -O1
In order, the following will be built (use -v for more details):
 - containers-tests-0 (lib) (first run)
 - containers-tests-0 (bench:intset-benchmarks) (first run)
Preprocessing library for containers-tests-0..
Error: cabal.exe: can't find source for Data\Containers\ListUtils in src,
tests,
C:\ghc\msys64\home\andi\repos\containers\dist-newstyle\build\x86_64-windows\ghc-9.4.2\containers-tests-0\build\autogen,
C:\ghc\msys64\home\andi\repos\containers\dist-newstyle\build\x86_64-windows\ghc-9.4.2\containers-tests-0\build\global-autogen

Error: cabal.exe: Failed to build containers-tests-0 (which is required by
bench:intset-benchmarks from containers-tests-0).

Maybe some symbolic link use that breaks on windows?

Activity

treeowl

treeowl commented on Dec 23, 2022

@treeowl
treeowl
on Dec 23, 2022
Contributor

Hmmm... Yeah, I think we use symbolic links to share files between containers and containers-tests. Do you know a better way?

AndreasPK

AndreasPK commented on Dec 23, 2022

@AndreasPK
AndreasPK
on Dec 23, 2022
ContributorAuthor

Indeed

andi@Ryzen MINGW64 ~/repos/containers
$ cat containers-tests/src
../containers/src

But this should be a symbolic link.

Seems more compatible to me to use

  hs-source-dirs:   ../containers/src, tests

Inside containers-tests.cabal instead of using a symbolic link. As they are notoriously difficult to get to work by default on windows.

treeowl

treeowl commented on Dec 23, 2022

@treeowl
treeowl
on Dec 23, 2022
Contributor

Can you try it and open a PR?

AndreasPK

AndreasPK commented on Dec 23, 2022

@AndreasPK
AndreasPK
on Dec 23, 2022
ContributorAuthor

I opened #886

AndreasPK
linked a pull request that will close this issue on Dec 23, 2022
meooow25
added
maintainability
on Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    maintainability

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @treeowl@AndreasPK@meooow25

      Issue actions
        intset-benchmarks no longer build on windows. · Issue #885 · haskell/containers