Re CLC issue 292 Avoid using partial init and last #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have converted the pull request to draft because it has been suggested that, compared to other approaches, |
|
Sorry, I missed this PR when submitting #275, which superseds it. I think the PR can be closed now. |
|
test code still needs fixing. Lemme go fix it. |
|
OK done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this pull request is:
At some point, GHC versions may warn that
initandlastare partial, giving advice about alternatives (includingunsnoc). This pull request seeks to anticipate that, by avoiding the use of partial functions at the two places where thetimepackage usesinitand/orlast.