Skip to content

HIB-129: Rework the Hibernate Tools landing page to reflect the actual situation #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

koentsje
Copy link
Member

No description provided.

Signed-off-by: Koen Aers <koen.aers@gmail.com>
@koentsje koentsje requested review from yrodiere and gavinking April 10, 2025 10:47
@gavinking
Copy link
Member

@koentsje looks good, I've left some suggestions.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, thanks! A few suggestions below.


An editor for Hibernate XML mapping files, supporting auto-completion and syntax highlighting.
The editor even supports semantic auto-completion for class names, property/field names, table names and column names.
image::/tools/images/reveng.png[Reverse Engineering]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really can be generated using the Maven/Ant/Gradle plugins? That's awesome.

-----


Of course all these defaults can be overridden and tuned. Please consult the documentation for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine we don't have a link? 🙈

Suggested change
Of course all these defaults can be overridden and tuned. Please consult the documentation for more information.
Of course all these defaults can be overridden and tuned. Please consult https://some.link.org/foo[the documentation] for more information.

Co-authored-by: Gavin King <gavin@hibernate.org>
Co-authored-by: Yoann Rodière <yoann@hibernate.org>
@koentsje
Copy link
Member Author

koentsje commented May 6, 2025

The PR was rebased against the production branch with the suggested changes included and merged into production.

@koentsje koentsje closed this May 6, 2025
@koentsje koentsje deleted the HIB-129 branch May 6, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants