-
-
Notifications
You must be signed in to change notification settings - Fork 111
Document Grid and Legend Options #1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the documentation by adding Grid and Legend options to the reference docs, addressing issue #1575.
- Added a hyperlink and navigation entry in the plotting options index.
- Introduced a new notebook (grid_legend.ipynb) documenting the Grid and Legend options with relevant examples.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
doc/ref/plotting_options/index.md | Added a link to the new grid_legend page and updated table navigation. |
doc/ref/plotting_options/grid_legend.ipynb | Contains a new notebook with detailed examples on grid and legend options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a weird page, with colorbar
that is not a grid or legend option, grid
the only Grid option, and legend
the only Legend option :D
"(option-legend)=\n", | ||
"## `legend`\n", | ||
"\n", | ||
"Controls whether and where the legend appears. Use `legend=True` (or `legend='right'`) to show it in the default position, `legend=False` to hide it, or supply one of ('top','bottom','left','right') to choose its placement." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It accepts other options like bottom_left
. Can you please find out all the options it accepts (check if they work for bokeh and matplotlib just in case) and list them all? The docstring needs to be updated too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs to be documented.
Maybe in future we will have more options in this section :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
fixes #1575
This PR adds the Grid and Legend options to the reference docs.