Skip to content

Document Grid and Legend Options #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 22, 2025
Merged

Document Grid and Legend Options #1576

merged 7 commits into from
May 22, 2025

Conversation

Azaya89
Copy link
Collaborator

@Azaya89 Azaya89 commented May 13, 2025

fixes #1575

This PR adds the Grid and Legend options to the reference docs.

@Azaya89 Azaya89 self-assigned this May 13, 2025
@Azaya89 Azaya89 requested a review from Copilot May 14, 2025 08:11
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the documentation by adding Grid and Legend options to the reference docs, addressing issue #1575.

  • Added a hyperlink and navigation entry in the plotting options index.
  • Introduced a new notebook (grid_legend.ipynb) documenting the Grid and Legend options with relevant examples.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
doc/ref/plotting_options/index.md Added a link to the new grid_legend page and updated table navigation.
doc/ref/plotting_options/grid_legend.ipynb Contains a new notebook with detailed examples on grid and legend options.

@Azaya89 Azaya89 requested a review from maximlt May 14, 2025 15:51
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a weird page, with colorbar that is not a grid or legend option, grid the only Grid option, and legend the only Legend option :D

"(option-legend)=\n",
"## `legend`\n",
"\n",
"Controls whether and where the legend appears. Use `legend=True` (or `legend='right'`) to show it in the default position, `legend=False` to hide it, or supply one of ('top','bottom','left','right') to choose its placement."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It accepts other options like bottom_left. Can you please find out all the options it accepts (check if they work for bokeh and matplotlib just in case) and list them all? The docstring needs to be updated too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs to be documented.

@Azaya89
Copy link
Collaborator Author

Azaya89 commented May 15, 2025

That's a weird page, with colorbar that is not a grid or legend option, grid the only Grid option, and legend the only Legend option :D

Maybe in future we will have more options in this section :)

@Azaya89 Azaya89 added the NF SDG 2025 NumFocus Software Development Grant 2025 label May 16, 2025
@Azaya89 Azaya89 marked this pull request as draft May 19, 2025 11:50
@Azaya89 Azaya89 marked this pull request as ready for review May 22, 2025 13:31
@Azaya89 Azaya89 requested a review from maximlt May 22, 2025 15:02
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@maximlt maximlt merged commit c140da2 into main May 22, 2025
11 checks passed
@maximlt maximlt deleted the grid-op branch May 22, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NF SDG 2025 NumFocus Software Development Grant 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the grid and legend options
2 participants