-
-
Notifications
You must be signed in to change notification settings - Fork 19
Add holoviews agent #1233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add holoviews agent #1233
Conversation
HoloViewsAgent now works in Lumen after changing | to Union[..., None] in the translator while that's being fixed in instructor. Then, I found a bunch of edge cases in the translator where pet = param.ClassSelector(class_=(Dog, Cat)) wasn't properly translating to pet: Union[Dog, Cat], handling instantiate=False and proposed that we migrate translate.py to param holoviz/param#828 (comment) Just need to wrap up translating operations and fixing those warnings |
383bf9c
to
5979db0
Compare
98c5766
to
e17df1d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
==========================================
- Coverage 57.07% 57.04% -0.04%
==========================================
Files 113 113
Lines 17612 17810 +198
==========================================
+ Hits 10052 10159 +107
- Misses 7560 7651 +91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolves #1231
More fixes to translate.py, prevent nested models from being streamed (since the model seems to switch between correct models then wrong models between each chunk), adds a base view between hvPlotView and HoloViewsView