Skip to content

Add holoviews agent #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add holoviews agent #1233

wants to merge 15 commits into from

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented May 13, 2025

Resolves #1231

More fixes to translate.py, prevent nested models from being streamed (since the model seems to switch between correct models then wrong models between each chunk), adds a base view between hvPlotView and HoloViewsView

@ahuang11
Copy link
Contributor Author

HoloViewsAgent now works in Lumen after changing | to Union[..., None] in the translator while that's being fixed in instructor.

Then, I found a bunch of edge cases in the translator where pet = param.ClassSelector(class_=(Dog, Cat)) wasn't properly translating to pet: Union[Dog, Cat], handling instantiate=False and proposed that we migrate translate.py to param holoviz/param#828 (comment)

Just need to wrap up translating operations and fixing those warnings
image

@ahuang11 ahuang11 changed the base branch from main to improve_translator May 14, 2025 23:08
@ahuang11 ahuang11 force-pushed the add_holoviews_agent branch from 383bf9c to 5979db0 Compare May 14, 2025 23:10
Base automatically changed from improve_translator to main May 15, 2025 15:39
@ahuang11 ahuang11 force-pushed the add_holoviews_agent branch from 98c5766 to e17df1d Compare May 15, 2025 17:47
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 67.27273% with 144 lines in your changes missing coverage. Please review.

Project coverage is 57.04%. Comparing base (4b47e4f) to head (25d05f1).

Files with missing lines Patch % Lines
lumen/ai/translate.py 71.32% 82 Missing ⚠️
lumen/views/base.py 68.53% 28 Missing ⚠️
lumen/ai/agents.py 20.58% 27 Missing ⚠️
lumen/ai/llm.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   57.07%   57.04%   -0.04%     
==========================================
  Files         113      113              
  Lines       17612    17810     +198     
==========================================
+ Hits        10052    10159     +107     
- Misses       7560     7651      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahuang11 ahuang11 marked this pull request as ready for review May 16, 2025 19:32
@droumis droumis requested a review from philippjfr May 21, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HoloViews ViewAgent
1 participant