-
Notifications
You must be signed in to change notification settings - Fork 3.2k
move default dashboard setting to user settings #25702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Which version are you targetting this PR for? There will be many custom components including Browser Mod that will need updating. I believe this should also be marked as breaking as currently there will be users who will have different Dashboards set as default for different devices for the same user, which is entirely possible with the existing standard UI and storage in localStorage. |
We are targeting the june release, so it goes in the same release as the sidebar changes that will have the same change. |
So that is tomorrow (11th June?). |
Yes |
The PR has not been reviewed, nor has the beta discussion mentioned changes for defaultPanel, only Sidebar Settings, for which I have made allowances and have a beta of Browser Mod with required changes. However now I will need to speed through custom component changes based on a PR that is yet to be reviewed and so may change. I find this all a bit rushed and no chance to adjust custom components to work with the change. This should be delayed until a June point release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have this issue when open the sidebar on my safari browser. But I don't have in with my Chrome browser (I guess it depends of the value in the local storage)
[Error] Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'this.hass.sidebar.panelOrder')
(fonction anonyme) (reactive-element.js:280)
[Error] Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'this.hass.sidebar.panelOrder')
performUpdate (reactive-element.js:280)
scheduleUpdate (reactive-element.js:765)
(fonction anonyme) (reactive-element.js:738)
I guess the sidebar object can be undefined...
EDIT : Looks like it was a cache issue on my side...
Also, some wording needs to be adapted : "Set as default on this device"
@bramkragten I have looked at the PR and have some review points for consideration.
Thank you for your time to consider these reveiw points. |
I kind of agree with your 2 point, and was thinking the same. But your first point, sorry, we just really don't support this, and I would like to ask you not to mess with stuff like this, as it will likely break, and then users will blame us... |
How else can a user clear their sidebar settings back to default? If there was a way for a user to do this then we can instruct them to use that way. |
Proposed change
Following the sidebar settings that are moved to the user settings, also move the setting for default dashboard to user settings.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: