Skip to content

Allow changing LLM Task preferences #25779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Allow changing LLM Task preferences #25779

merged 2 commits into from
Jun 20, 2025

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 13, 2025

Breaking change

Proposed change

Allow setting preferred entities for LLM Tasks.

CleanShot 2025-06-20 at 09 10 22@2x

Requires home-assistant/core#146734

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob force-pushed the llm-task-prefs branch 2 times, most recently from 0cca3ba to 464a77c Compare June 16, 2025 02:16
@balloob balloob force-pushed the llm-task-prefs branch 3 times, most recently from 806a58c to 0d6f768 Compare June 18, 2025 01:11
@balloob balloob marked this pull request as ready for review June 20, 2025 13:10
@@ -53,6 +54,12 @@ export class HaConfigVoiceAssistantsAssistants extends LitElement {
></assist-pref>
`
: nothing}
${isComponentLoaded(this.hass, "ai_task")
? html`<ai-task-pref
Copy link
Member

@bramkragten bramkragten Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should be on the voice assistants settings page, as it is not related to voice assistants but for tasks in the UI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's LLM related, which I guess sits "above" voice assistants. I don't really know the best place right now so just went for here. Would you prefer a different page ? It's like 1 dropdown right now…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok to merge for now I would say, I will ask UX for advice

bramkragten
bramkragten previously approved these changes Jun 20, 2025
@balloob balloob merged commit 52a0209 into dev Jun 20, 2025
15 checks passed
@balloob balloob deleted the llm-task-prefs branch June 20, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants