Fix: Match Solidity behavior for memory array deletion (issue #1785) #1795
+176
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptapratykshh
requested review from
seanyoung,
xermicus,
LucasSte and
salaheldinsoliman
as code owners
…dger-solang#1785) Signed-off-by: Pratyksh <pratykshgupta9999@gmail.com>
guptapratykshh
force-pushed
the
fix/1785-memory-array-delete
branch
from
f2d4df4 to
4de1994
Compare
seanyoung
requested changes
May 19, 2025
| } else { | ||
| // For memory arrays and other types, we should only delete the element | ||
| // by assigning the default value, not delete the entire array | ||
| // Issue #1785 - match Solc behavior for delete array[index] | ||
| ns.diagnostics.push(Diagnostic::warning( | ||
| *loc, | ||
| "argument to 'delete' should be storage reference".to_string(), |
There was a problem hiding this comment.
Here are you still generating a warning. Should be removed for array elements.
| right: Box::new(default_expr), | ||
| }; | ||
|
|
||
| res.push(Statement::Expression(*loc, true, assign)); |
There was a problem hiding this comment.
The problem here is that the AST should be an accurate representation of the source code, not of the code it will generate - that happens in codegen.
So in sema, add:
res.push(Statement::Delete(...);Then in codegen, for array elements, set a default value, here:
https://github.com/hyperledger-solang/solang/blob/main/src/codegen/statements/mod.rs#L217
| @@ -2752,3 +2775,64 @@ fn try_catch( | |||
|
|
|||
| Ok((stmt, finally_reachable)) | |||
| } | |||
|
|
|||
| /// Helper function to get the default value expression for a type | |||
| fn get_default_value( | |||
There was a problem hiding this comment.
We already have a function for default values in codegen. Let me know if you need some help locating it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes behavior of
deleteoperator when used with memory arrays to match Solidity's behavior. Previously, the delete operator was not correctly handling memory array elements, which could lead to unexpected behavior.Related Issue
Closes #1785