raid: R-V V pq_gen xor_gen #318
Closed
+341
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sunyuechi
commented
Mar 21, 2025
sunyuechi
commented
pablodelara
reviewed
Mar 21, 2025
|
Hi @hleft. Could you update Release Notes to add information about this and previous additions (e.g. adler32)? Also it would be good to update README to add info on RISC-V (can be done in a separate PR or this one, up to you). |
|
Okay, the Release Notes have been updated. I plan to update the README Prerequisites together with the PR that adds CI support. |
pablodelara
reviewed
Apr 22, 2025
|
Thanks for the update. Looks like there is a problem with the coding style, coming from a file that we recently add. I will fix it shortly, thanks! |
|
Due to the master branch update, xx_multibinary_riscv64_dispatcher.c has also been updated. |
|
@sunyuechi could you rebase this PR, so we trigger the latest CI? Thanks! |
|
Okay, rebased. |
pablodelara
reviewed
Apr 28, 2025
Signed-off-by: sunyuechi <sunyuechi@iscas.ac.cn>
banana_f3:
new: pq_gen_warm: runtime = 3062397 usecs, bandwidth 4737 MB in 3.0624 sec = 1546.92 MB/s
old: pq_gen_warm: runtime = 3005894 usecs, bandwidth 2851 MB in 3.0059 sec = 948.80 MB/s
Signed-off-by: sunyuechi <sunyuechi@iscas.ac.cn>
If len > 255, the return value will be % 256, which causes the test to incorrectly pass Signed-off-by: sunyuechi <sunyuechi@iscas.ac.cn>
banana_f3:
new: xor_gen_warm: runtime = 3006459 usecs, bandwidth 10685 MB in 3.0065 sec = 3554.17 MB/s
old: xor_gen_warm: runtime = 3060970 usecs, bandwidth 514 MB in 3.0610 sec = 168.21 MB/s
Signed-off-by: sunyuechi <sunyuechi@iscas.ac.cn>
Signed-off-by: sunyuechi <sunyuechi@iscas.ac.cn>
|
This is already merged in mainline, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.