Remove cross reference locally #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the local cross reference analysis code since cross reference analysis now happens remotely with improved logic. It removes the printing of local cross reference warnings, deletes the CrossRefResult model and its references from ScanPathResult, and eliminates the local check_cross_references method from MCPScanner.
- Removed local cross reference print logic in the printer module.
- Deleted the CrossRefResult model and its reference in the models.
- Removed the check_cross_references function and its call in the scanner.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mcp_scan/printer.py | Removed the printing of local cross reference warnings. |
| src/mcp_scan/models.py | Removed the CrossRefResult model and its usage in ScanPathResult. |
| src/mcp_scan/MCPScanner.py | Eliminated the check_cross_references function and its invocation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cross reference analysis happens remotly. Remotly it has been improved by looking for soft references.