Skip to content

Conversation

@csdechant
Copy link
Contributor

This PR adds additions and tests for MeshFunction::operator() that allows for Lagrange, Nedelec, and Raviart Thomas vector variables.

csdechant added 2 commits May 6, 2025 14:28
… 'FEInterface::vectorshape' for vector shape functions
… calling Gradient output for MeshFunction::operator()
@moosebuild
Copy link

Job Test MOOSE clang on b2cfed7 : invalidated by @roystgnr

problems/eigen_problem/arraykernels.eigen/two_variables_precond_include_eigen_kernels CSVDiff, only with threads? Got to be a bug downstream, not this PR.

@moosebuild
Copy link

moosebuild commented May 8, 2025

Job Coverage, step Generate coverage on f3d95aa wanted to post the following:

Coverage

5868ff #4165 f3d95a
Total Total +/- New
Rate 64.28% 64.31% +0.03% 93.48%
Hits 75108 75168 +60 43
Misses 41736 41712 -24 3

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@csdechant csdechant force-pushed the vector-mesh_function branch from b2cfed7 to ccbd4fc Compare May 13, 2025 17:12
Copy link
Member

@roystgnr roystgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting closer now, and this is important enough and new enough that I could wince and merge something with bad asymptotic performance that we can fix later, but we've got to be able to handle the mixed-vector-and-scalar use case, not add a new API that'll make adding that handling harder later.

@csdechant csdechant requested a review from roystgnr May 29, 2025 21:54
csdechant and others added 2 commits July 14, 2025 13:10
@csdechant csdechant requested a review from roystgnr July 21, 2025 14:14
Copy link
Member

@roystgnr roystgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm happy with this now. Unless someone else chimes in with complaints first we should merge tomorrow.

@roystgnr roystgnr merged commit d5d9022 into libMesh:devel Jul 22, 2025
20 checks passed
roystgnr added a commit to roystgnr/libmesh that referenced this pull request Aug 4, 2025
This should fix a regression from libMesh#4165

I do not understand why this regression is only killing our builds on
ARM Mac systems.

I do not understand why this regression is not killing builds on my ARM
Mac laptop.

I do not understand why `make` doesn't give a clearer error message than
"missing separator" about this.
@roystgnr roystgnr mentioned this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants