-
Notifications
You must be signed in to change notification settings - Fork 299
Vector Variable Output for Mesh Function #4165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… 'FEInterface::vectorshape' for vector shape functions
… calling Gradient output for MeshFunction::operator()
|
Job Test MOOSE clang on b2cfed7 : invalidated by @roystgnr problems/eigen_problem/arraykernels.eigen/two_variables_precond_include_eigen_kernels CSVDiff, only with threads? Got to be a bug downstream, not this PR. |
…able outputs for MeshFunction::operator() Closes libMesh#3714
b2cfed7 to
ccbd4fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting closer now, and this is important enough and new enough that I could wince and merge something with bad asymptotic performance that we can fix later, but we've got to be able to handle the mixed-vector-and-scalar use case, not add a new API that'll make adding that handling harder later.
Co-authored-by: roystgnr <roy@stogners.org>
Co-authored-by: roystgnr <roy@stogners.org>
…' in mesh_function.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm happy with this now. Unless someone else chimes in with complaints first we should merge tomorrow.
This should fix a regression from libMesh#4165 I do not understand why this regression is only killing our builds on ARM Mac systems. I do not understand why this regression is not killing builds on my ARM Mac laptop. I do not understand why `make` doesn't give a clearer error message than "missing separator" about this.
This PR adds additions and tests for MeshFunction::operator() that allows for Lagrange, Nedelec, and Raviart Thomas vector variables.