Skip to content

Remove redundant prepare_send_list() calls #4183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2025
Merged

Remove redundant prepare_send_list() calls #4183

merged 2 commits into from
Jun 4, 2025

Conversation

roystgnr
Copy link
Member

@roystgnr roystgnr commented Jun 2, 2025

Thanks to @lindsayad for catching one of these.

roystgnr added 2 commits June 2, 2025 17:13
@roystgnr
Comment on reinit_constraints() side effect
41a8500
@roystgnr
Don't prepare_send_list after reinit_constraints
1080098 
It's redundant in that case.

Thanks to Alex Lindsay for catching one of these.
@moosebuild
Copy link

Job Coverage, step Generate coverage on 1080098 wanted to post the following:

Coverage

fb6cd8 #4183 108009
Total Total +/- New
Rate 63.59% 62.83% -0.77% -
Hits 75705 74790 -915 0
Misses 43341 44251 +910 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@lindsayad
Copy link
Member

Ah I see that the MOOSE test is biting others as well. I have a change at idaholab/moose#30658

@lindsayad lindsayad mentioned this pull request Jun 4, 2025
Merged
@roystgnr
Copy link
Member Author

roystgnr commented Jun 4, 2025

That new exodiff is consistently the only failure, so this should be good to go.

@roystgnr roystgnr merged commit 105d6bb into libMesh:devel Jun 4, 2025
15 of 20 checks passed
@roystgnr roystgnr deleted the fix_redundant_send_list_work branch June 4, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roystgnr @moosebuild @lindsayad