set screen dimension when parsing to save lines of code; add experimental camera center; remove traces; fix resizing the sample

Author: loudoweb

README.md

@@ -7,14 +7,11 @@ There is a sample with openfl that can help use this library in any engine.
 
 - parallax scrolling constrained by a defined world dimension
 - configurable by xml (or code)
-- zoom
+- zoom constrained by screen height
 - sample (openfl)
 - agnostic
 
 # Demo
 
 The sample can be tested here (better fullscreen): http://loudoweb.fr/app/parallax/
-	
-# known issue
-
-The app is constrained by the world dimension. But it lacks screen dimension constrain. So now the app works better fullscreen. (A fix is coming).
+And here is the [xml](https://github.com/loudoweb/parallax/blob/master/assets/data/parallax.xml)

assets/data/parallax.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
-<data id="test" camX="1000" camY="250" width="4000" height="1500">
+<data id="test" camX="1000" camY="250" width="4200" height="1500">
 	<layers>
 		<layer id="sky" depth="0">
 			<sprite img="_11_background" />
@@ -16,30 +16,37 @@
 		<layer id="big-clouds" depth="0.28">
 			<sprite img="_07_huge_clouds" />
 			<sprite img="_07_huge_clouds" x="2048" />
+			<sprite img="_07_huge_clouds" x="4096" />
 		</layer>
 		<layer id="hills" depth="0.45">
 			<sprite img="_06_hill2" />
 			<sprite img="_06_hill2" x="2048" />
+			<sprite img="_06_hill2" x="4096" />
 		</layer>
 		<layer id="hills2" depth="0.5">
 			<sprite img="_05_hill1" />
 			<sprite img="_05_hill1"  x="2048" />
+			<sprite img="_05_hill1"  x="4096" />
 		</layer>
 		<layer id="brushes" depth="0.7">
 			<sprite img="_04_bushes" />
 			<sprite img="_04_bushes" x="2048" />
+			<sprite img="_04_bushes" x="4096" />
 		</layer>
 		<layer id="distant-trees" depth="0.75">
 			<sprite img="_03_distant_trees" />
 			<sprite img="_03_distant_trees" x="2048" />
+			<sprite img="_03_distant_trees" x="4096" />
 		</layer>
 		<layer id="trees" depth="0.95">
 			<sprite img="_02_trees and bushes" />
 			<sprite img="_02_trees and bushes" x="2048" />
+			<sprite img="_02_trees and bushes" x="4096" />
 		</layer>
 		<layer id="ground" depth="1">
 			<sprite img="_01_ground" />
 			<sprite img="_01_ground" x="2048" />
+			<sprite img="_01_ground" x="4096" />
 		</layer>
 	</layers>
 </data>

parallax.hxproj

@@ -24,7 +24,7 @@
   </classpaths>
   <!-- Build options -->
   <build>
-    <option directives="openfl=9.1.0&#xA;lime=7.9.0&#xA;actuate=1.8.9&#xA;ANDROID_SETUP=true&#xA;ANDROID_NDK_ROOT=C:\Development\Android\NDK\android-ndk-r15c&#xA;howlerjs&#xA;lime-webgl&#xA;lime-dom&#xA;lime-howlerjs&#xA;lime-html5&#xA;openfl-disable-handle-error&#xA;HL_PATH=C:\Development\hl-1.10.0-win&#xA;gs&#xA;tools=7.9.0&#xA;ANDROID_SDK=C:\Development\Android\SDK\platforms\android-26&#xA;lime-canvas&#xA;no-compilation&#xA;openfl-html5&#xA;JAVA_HOME=C:\Program Files (x86)\java\jdk1.8.0&#xA;HXCPP_COMPILE_CACHE=E:\hxcpp\cache&#xA;fdb&#xA;html5&#xA;web&#xA;html5" />
+    <option directives="openfl=9.1.0&#xA;lime=7.9.0&#xA;actuate=1.8.9&#xA;ANDROID_SETUP=true&#xA;ANDROID_NDK_ROOT=C:\Development\Android\NDK\android-ndk-r15c&#xA;howlerjs&#xA;lime-webgl&#xA;lime-dom&#xA;lime-howlerjs&#xA;lime-html5&#xA;openfl-disable-handle-error&#xA;HL_PATH=C:\Development\hl-1.10.0-win&#xA;tools=7.9.0&#xA;ANDROID_SDK=C:\Development\Android\SDK\platforms\android-26&#xA;lime-canvas&#xA;no-compilation&#xA;openfl-html5&#xA;JAVA_HOME=C:\Program Files (x86)\java\jdk1.8.0&#xA;HXCPP_COMPILE_CACHE=E:\hxcpp\cache&#xA;fdb&#xA;html5&#xA;web&#xA;html5" />
     <option flashStrict="False" />
     <option noInlineOnDebug="False" />
     <option mainClass="ApplicationMain" />

parallax/Parallax.hx

@@ -75,11 +75,10 @@ class Parallax
 		//trace("image height", height / camera.zoom, "stage", screenY);
 		camera.deltaZoom = (1 - camera.minZoom) / 2;
 		camera.maxZoom = 1 + camera.deltaZoom *2;
-		trace(camera.minZoom, camera.zoom, camera.maxZoom, camera.deltaZoom);
-		
 
+		//to have zoom with 5 values
 		var values = [for (i in 0...5) i * camera.deltaZoom + camera.minZoom];
-		//find closest zoom to current
+		//find closest zoom to current (when screen dimension changes)
 		var closest = 42.;
 		for (item in values)
 		{
@@ -89,7 +88,6 @@ class Parallax
 
 		if (closest != camera.zoom)
 		{
-			trace("resize", camera.minZoom, "old", camera.zoom, "closest", closest, camera.maxZoom);
 			camera.zoom = closest;
 			//this.zoomOffsetX = zoomOffsetX;
 			//this.zoomOffsetY = zoomOffsetY;
@@ -145,14 +143,24 @@ class Parallax
 		updateLayers();
 	}
 
-	public static function parse(xml:Xml):Parallax
+	public static function parse(xml:Xml, screenWidth:Int = 1920, screenHeight:Int = 1080):Parallax
 	{
 		var _xml = new Access(xml.firstElement());
 		var world = new Parallax(_xml.has.id ? _xml.att.id : "world", _xml.has.world ? _xml.att.world : "", _xml.getFloat("camX"), _xml.getFloat("camY"));
 		if (_xml.has.width)
 			world.width = Std.parseFloat(_xml.att.width);
 		if (_xml.has.height)
 			world.height = Std.parseFloat(_xml.att.height);
+			
+		world.camera.width = screenWidth;
+		world.camera.height = screenHeight;
+		
+		var useCenterPos = _xml.getBool("useCenterPos", false);
+		if (useCenterPos)
+		{
+			world.camera.x -= screenWidth/2;
+			world.camera.y -= screenHeight/2;
+		}
 
 		if (world.layers == null)
 			world.layers = [];

parallax/ParallaxCamera.hx

@@ -26,8 +26,8 @@ class ParallaxCamera
 
 	/**
 	 * 
-	 * @param	x starting position of the camera
-	 * @param	y starting position of the camera
+	 * @param	x starting position of the camera (top left corner of camera)
+	 * @param	y starting position of the camera (top left corner of camera)
 	 * @param	width
 	 * @param	height
 	 * @param	zoom

sample/OpenflSample.hx

@@ -33,7 +33,7 @@ class OpenflSample extends Sprite
 
 		//parallax
 		var xml = Xml.parse(Assets.getText("parallax.xml"));
-		parallax = Parallax.parse(xml);
+		parallax = Parallax.parse(xml, stage.stageWidth, stage.stageHeight);
 
 		containers = [];
 
@@ -57,7 +57,6 @@ class OpenflSample extends Sprite
 				OpenflHelper.setWorldBounds(parallax, layer, spr);
 			}
 		}
-				
 		parallax.setZoomBounds(stage.stageHeight);		
 
 		stage.addEventListener(MouseEvent.MOUSE_WHEEL, onWheel);
@@ -68,8 +67,8 @@ class OpenflSample extends Sprite
 
 	function onResize(e:Event):Void
 	{
-		//parallax.camera.width = stage.stageWidth;
-		//parallax.camera.height = stage.stageHeight;
+		parallax.camera.width = stage.stageWidth;
+		parallax.camera.height = stage.stageHeight;
 		parallax.setZoomBounds(stage.stageHeight);
 	}