Skip to content

(common) bump docker version to 25.0.3 #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: production
Choose a base branch
from

Conversation

dtapiacl
Copy link
Contributor

@dtapiacl dtapiacl commented May 12, 2025

Bump docker version along with related packages.

Im testing this on test01.ls.lsst.org with ess role applied.

@dtapiacl dtapiacl self-assigned this May 12, 2025
@dtapiacl dtapiacl changed the title It 6158 bump docker version (common) bump docker version May 12, 2025
@dtapiacl dtapiacl force-pushed the IT-6158_bump_docker_version branch from 8176552 to 458323d Compare May 12, 2025 17:23
@dtapiacl dtapiacl added the enhancement New feature or request label May 12, 2025
@dtapiacl dtapiacl force-pushed the IT-6158_bump_docker_version branch 2 times, most recently from 77abc89 to 6394442 Compare May 12, 2025 18:59
@dtapiacl dtapiacl changed the title (common) bump docker version (common) bump docker version to 25.0.3 May 14, 2025
@dtapiacl dtapiacl force-pushed the IT-6158_bump_docker_version branch 10 times, most recently from d834e49 to 4ae7781 Compare May 20, 2025 18:19
@dtapiacl dtapiacl marked this pull request as ready for review May 20, 2025 18:19
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests on almalinux 8 are failing because only the package names for el9 have been updated.

@dtapiacl dtapiacl force-pushed the IT-6158_bump_docker_version branch 2 times, most recently from c00f583 to 0042ecd Compare May 22, 2025 17:34
@dtapiacl dtapiacl requested a review from jhoblitt May 22, 2025 17:35
@dtapiacl dtapiacl force-pushed the IT-6158_bump_docker_version branch 3 times, most recently from 1e31929 to 4aa43b0 Compare May 27, 2025 18:04
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit title (major/9.yaml) isn't helpful as it is ambiguous as to which hiera layer is being modified and the commit is modifying multiple layers.
image

My recommended fix is to squash everything into a single commit.

@dtapiacl dtapiacl force-pushed the IT-6158_bump_docker_version branch 2 times, most recently from 9471f28 to 2a0f235 Compare June 3, 2025 15:13
@dtapiacl dtapiacl requested a review from jhoblitt June 3, 2025 15:20
@dtapiacl dtapiacl force-pushed the IT-6158_bump_docker_version branch 2 times, most recently from 3fefbc0 to 2491437 Compare June 5, 2025 18:12
@dtapiacl dtapiacl force-pushed the IT-6158_bump_docker_version branch from 2491437 to d3fcb05 Compare June 9, 2025 13:57
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Please state in the commit title was the version is being changed too. Once that's done, this PR is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants