Skip to content

fix: temp fix to prevent 503 retries on servers page #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

IMB11
Copy link
Member

@IMB11 IMB11 commented Jun 4, 2025

Will be completely refactoring pyroServers.ts & pyroFetch.ts in a later PR - it's a mess, some of the options don't work (such as retry: false)

Closes: DEV-19

@IMB11 IMB11 requested a review from Copilot June 4, 2025 22:41
@IMB11 IMB11 added bug Something isn't working frontend labels Jun 4, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a temporary fix to prevent retry attempts on 503 status responses on the servers page.

  • Removes HTTP status code 503 from the list of retryable status codes.
  • Aims to reduce unnecessary retry behavior until a complete refactor is performed.
Comments suppressed due to low confidence (1)

apps/frontend/src/composables/pyroServers.ts:210

  • Consider adding an inline comment explaining the removal of 503 from the retryable status codes list for clarity, so future maintainers understand this temporary decision.
const isRetryable = statusCode ? [408, 429, 500, 502, 504].includes(statusCode) : true;

@IMB11
Copy link
Member Author

IMB11 commented Jun 6, 2025

Replaced by #3745

@IMB11 IMB11 closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Development

Successfully merging this pull request may close these issues.

1 participant