Migrate Java code to Gradle #3833
Conversation
If the tauri feature is enabled, the resource will be loaded from Tauri resources. If the tauri feature is disabled, the resource will be extracted to a temp directory.
Gaming32
added
app
There was a problem hiding this comment.
I agree that it's great to have a documented, automated, and reproducible way to build these helper Java scripts. That said, I find Gradle a bit too feature and boilerplate heavy for such simple single-file, no dependency scripts, especially when they are very likely to remain that way.
Have you considered using alternatives like Makefiles, xtasks, plain npm scripts, Task, Just, classic shell scripts, or something else along those simpler lines instead?
# Conflicts: # apps/app/tauri.conf.json # packages/app-lib/src/launcher/mod.rs # packages/app-lib/src/util/io.rs # packages/app-lib/src/util/jre.rs
| }; | ||
|
|
||
| (env $dir_env_name:literal / $file_name:literal) => { | ||
| get_resource_file!(directory: env!($dir_env_name), file: $file_name) |
There was a problem hiding this comment.
The compile error that happens here is quite tricky, because you indeed define the JAVA_JARS_DIR environment variable correctly in the build script. After some fiddling, I realized that if I moved its instruction before Gradle is executed it works fine. I'm not sure why exactly that helps, as the Rust compiler has to wait until the build script completes to build the actual crate anyway, so no race condition should be happening here... Probably.
# Conflicts: # packages/app-lib/java/src/main/java/com/modrinth/theseus/JavaInfo.java # packages/app-lib/java/src/main/java/com/modrinth/theseus/MinecraftLaunch.class # packages/app-lib/java/src/main/java/com/modrinth/theseus/MinecraftLaunch.java # packages/app-lib/src/launcher/mod.rs # packages/app-lib/src/util/io.rs # packages/app-lib/src/util/jre.rs
An unforeseen consequence of PR #3833 landing was that `tauri dev` stopped working reliably, getting softlocked when the `app-lib` crate build script actually needed to build Java scripts: Gradle always modifies a few files under the `.gradle` directory when run, which get picked up by Tauri as source code changes that should trigger a rebuild, but such rebuild triggers Gradle to run and modify those files again ad infinitum. This change fixes that by adding such a directory to a documented Tauri exclusion file, restoring such functionality back.
…ked (#3847) An unforeseen consequence of PR #3833 landing was that `tauri dev` stopped working reliably, getting softlocked when the `app-lib` crate build script actually needed to build Java scripts: Gradle always modifies a few files under the `.gradle` directory when run, which get picked up by Tauri as source code changes that should trigger a rebuild, but such rebuild triggers Gradle to run and modify those files again ad infinitum. This change fixes that by adding such a directory to a documented Tauri exclusion file, restoring such functionality back.
Java code in Theseus has historically been compiled using
javacmanually on the command-line, which is tedious and error-prone. This PR moves it to being compiled with Gradle.