Show already-loaded low-res gallery image while full image loads #3844
+36
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…res image is loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just me fixing an annoyance I personally had - the user had no indication that, when they pressed an arrow key in the gallery, that anything had happened, since the new image needed to load before anything changes. This PR makes it so it immediately displays the low-res preview image whilst the full-res image loads so that the user knows stuff is happening.
I'm aware the min-width and min-height stuff isn't really ideal - open to suggestions, but we don't have the dimensions of the full image so I'm not sure how it should be sized.
(The force push is just be forgetting to run fix)