-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Revert ESM update for toolpad-core #4745
Conversation
Netlify deploy preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I had actually ran into this too but wasn't sure if this was the fix.
Oh wait, I guess we need to update the versions for development, the playground apps and the examples accordingly? |
Yes, and I haven't tested what this does for Studio |
Hopefully nothing too breaking, I'll try in a separate PR. |
@apedroferreira I'm reverting this until X publishes their beta. Core v7 is not compatible with X v7. |
Seems to have fixed the issue, just tested with the CodeSandbox version! The |
I'll fix this in core |
Wait for both X and core to be in beta with their updated package layout before making this change to
@toolpad/core
. We can keep it for@toolpad/utils
.