Skip to content

feat: added 'alt' and 'dist' to ground fix schema #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v1
Choose a base branch
from

Conversation

coleHafner
Copy link
Contributor

** THIS IS WILL NOT BE MERGED UNTIL EARLY DEC WHEN FEATURE IS RELEASED ON BE **

Problem

Backend has new flags that are not documented here.

Solution

Document them!

Testing

npm test

Front End Changes Required

NONE

System Impact

NONE

Jira Tickets

IRIS-9796

Release Notes

Added docs for 'dist' and 'alt' flags on ground fix endpoint

Copy link
Contributor

@plskeggs plskeggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok, but we will be unable to add to the device side anytime soon.

@coleHafner coleHafner marked this pull request as ready for review October 21, 2024 18:53
Copy link
Contributor

@lincolnthomas lincolnthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I understand this won't be merged until the changes have been deployed to Production.

@lincolnthomas
Copy link
Contributor

Seems ok, but we will be unable to add to the device side anytime soon.

The schema can be published independently of any future firmware support, so this is OK.

@plskeggs
Copy link
Contributor

@coleHafner is this delayed until future notice?

@coleHafner
Copy link
Contributor Author

@plskeggs this is available on the REST API. I believe MQTT too, but will double check tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants