fix: use ipairs in functional.all and add basic test coverage #659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(functional): use ipairs in
all
to avoid incorrect iteration over tablesPreviously,
functional.all
usedpairs
, which can iterate non-numeric keysand lead to incorrect behavior when passed list-style tables.
This patch switches to
ipairs
, preserving the existing (k, v) arity of thepredicate function but ensuring predictable, index-ordered traversal.
Added test coverage for
all
, including cases for full match, partial failure,and empty input.