Skip to content

Split existing rules into separate rulesets #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 24, 2025

Conversation

saberzero1
Copy link
Contributor

@saberzero1 saberzero1 commented Jun 9, 2025

Closes #26

  • Split up the five commands messages into five rules under command/
  • Split up the four settingsTab messages into two rules under settingsTab/
    • I decided to combine settings, general, and pluginName, as these are all relevant for the heading text content. (no "settings", no "general", and no plugin name in heading respectively".
    • The other rule, no-manual-html-headings, can now be automatically fixed with --fix due to the split.
  • Moved the vaultIterate rule into vault/iterate, as there will probably be more vault-related rules. (Perhaps this rule should be moved to vault/.

@saberzero1 saberzero1 changed the title Split commands Split existing commands into separate rules Jun 9, 2025
@saberzero1 saberzero1 marked this pull request as ready for review June 9, 2025 10:36
@saberzero1 saberzero1 changed the title Split existing commands into separate rules Split existing rules into separate rulesets Jun 9, 2025
@joethei joethei mentioned this pull request Jun 24, 2025
@joethei joethei merged commit cba8280 into obsidianmd:master Jun 24, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split up rules/commands & rules/settingsTab into separate rules, one for each message
2 participants