Skip to content

Extend Profiler to allow for non-timing info #18631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 1, 2025

Conversation

neuenfeldttj
Copy link
Contributor

Description

This is a smaller PR that helps solve #18460. Timer now extends a new class called ProfileMetric. The new code works how the current profiler code works but allows a breakdown to output all information (timers and non-timers). This will be useful for plugins once plugin profiling is supported. Concurrency is also achieved by determining the timers/non-timers and aggregating accordingly. Also, enums were eliminated from the generics so that the profiler could be more extensible and support this.

Related Issues

Resolves part of #18486
Resolves part of #18460

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
Copy link
Contributor

❌ Gradle check result for 0086e78: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
Copy link
Contributor

❌ Gradle check result for a57cbaf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
Copy link
Contributor

❌ Gradle check result for 6cce78a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
Copy link
Contributor

❌ Gradle check result for 179a190: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Contributor

reta commented Jun 30, 2025

Thanks for this work, @neuenfeldttj the change is really look great (at least to me), we should be close to finish it, thank you

Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
Copy link
Contributor

❌ Gradle check result for 0f9e007: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
Copy link
Contributor

❌ Gradle check result for 60e9e77: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
Copy link
Contributor

❌ Gradle check result for d22ebd6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for d22ebd6: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for d22ebd6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
@reta
Copy link
Contributor

reta commented Jun 30, 2025

One last thing (sorry, I missed it before), but LGTM otherwise, thank you @neuenfeldttj !

Copy link
Contributor

github-actions bot commented Jul 1, 2025

❌ Gradle check result for 4be314f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
Copy link
Contributor

github-actions bot commented Jul 1, 2025

❕ Gradle check result for 8565746: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

@jed326 jed326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neuenfeldttj, this looks like a lot of really useful plumbing work related to profiling. I'll defer to @reta for final approval and merging, but just had one small comment.

@jed326 jed326 added the v3.2.0 label Jul 1, 2025
Copy link
Contributor

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neuenfeldttj , great work! Thanks @jed326 for review!

@reta reta added the Search Search query, autocomplete ...etc label Jul 1, 2025
@reta reta merged commit 8fd9aeb into opensearch-project:main Jul 1, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Search Search query, autocomplete ...etc v3.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants